Detect cyclic subtype goals in new solver #110202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
|
whoops r? @lcnr |
compiler-errors
force-pushed
the
cyclic-subtype-goals
branch
from
a91610f
to
057be66
Compare
compiler-errors
force-pushed
the
cyclic-subtype-goals
branch
from
057be66
to
1bf887c
Compare
compiler-errors
force-pushed
the
cyclic-subtype-goals
branch
from
1bf887c
to
f4c695a
Compare
|
is this only to not get fulfillment overflow? because i personally would like to avoid this and just accept that fulfillment overflows for these 🤔 |
|
Decided against this I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bubble up subtyping relations that become stalled so that the generalizer can eagerly detect cyclic responses to goals such as
?0 <: Box<?1>when?0 <: ?1is already a registered subtype obligation. Otherwise, processing these two in tandem will cause us to repeatedly substitute and get a runaway type.Fixes compiler-errors/next-solver-hir-issues#18
Opening for discussion mostly.